feat: add plugin disable and enable commands

2026-07-01 10:42:18 -07:00
parent de0b20fa61
commit 13b1840ba0
3 changed files with 240 additions and 5 deletions
@@ -14,7 +14,7 @@ from plugin_helper.beatmods import by_version_id, normalize_mods
 from plugin_helper.checker import check_lock
 from plugin_helper.cli import installed_plugins_report, run
 from plugin_helper.fsutil import sha256_file
-from plugin_helper.installer import apply_plan, uninstall_plugin
+from plugin_helper.installer import apply_plan, disable_plugin, uninstall_plugin
 from plugin_helper.instances import get_instance, list_instances
 from plugin_helper.models import Lockfile, LockedPlugin, Registry, RegistryPlugin
 from plugin_helper.planner import create_plan
@@ -242,6 +242,127 @@ class PluginHelperTests(unittest.TestCase):
            self.assertEqual(removed["removed"], ["Plugins/Example.dll"])
            self.assertFalse((instance / "Plugins" / "Example.dll").exists())

+    def test_disable_plugin_removes_files_but_keeps_disabled_state(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            work = Path(tmp)
+            instance = work / "instances" / "1.40.8"
+            state = work / "state"
+            instance.mkdir(parents=True)
+            (instance / "Beat Saber_Data").mkdir()
+            (instance / "Plugins").mkdir()
+
+            target = instance / "Plugins" / "Example.dll"
+            target.write_bytes(b"managed dll")
+            installed = {
+                "instance": "1.40.8",
+                "plugins": {
+                    "example": {
+                        "installedAt": "2026-06-14T17:18:40Z",
+                        "files": [
+                            {
+                                "path": "Plugins/Example.dll",
+                                "sha256": sha256_file(target),
+                                "size": target.stat().st_size,
+                            }
+                        ],
+                    }
+                },
+            }
+            from plugin_helper.state import save_installed_state
+
+            save_installed_state(state, "1.40.8", installed)
+
+            result = disable_plugin("1.40.8", instance, state, "example")
+
+            self.assertEqual(result["removed"], ["Plugins/Example.dll"])
+            self.assertFalse(target.exists())
+            updated = load_installed_state(state, "1.40.8")
+            self.assertNotIn("example", updated["plugins"])
+            self.assertIn("example", updated["disabledPlugins"])
+            self.assertEqual(updated["disabledPlugins"]["example"]["files"][0]["path"], "Plugins/Example.dll")
+
+    def test_enable_command_reinstalls_disabled_plugin_from_asset(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            work = Path(tmp)
+            instance_root = work / "instances"
+            instance = instance_root / "1.40.8"
+            state = work / "state"
+            registry_dir = work / "registry"
+            locks_dir = work / "locks"
+            registry_dir.mkdir()
+            locks_dir.mkdir()
+            instance.mkdir(parents=True)
+            (instance / "Beat Saber_Data").mkdir()
+            (instance / "Plugins").mkdir()
+
+            asset = plugin_downloads_dir(state, "1.40.8", "example") / "Example.dll"
+            asset.write_bytes(b"managed dll")
+            (registry_dir / "plugins.toml").write_text(
+                """
+[[plugins]]
+id = "example"
+name = "Example"
+repo = "owner/example"
+asset_patterns = ["*.dll"]
+install_strategy = "dll-to-plugins"
+""".lstrip(),
+                encoding="utf-8",
+            )
+            (locks_dir / "1.40.8.lock.toml").write_text(
+                f"""
+beat_saber_version = "1.40.8"
+instance = "1.40.8"
+
+[[plugins]]
+id = "example"
+repo = "owner/example"
+tag = "v1.0.0"
+asset = "Example.dll"
+sha256 = "{sha256_file(asset)}"
+""".lstrip(),
+                encoding="utf-8",
+            )
+            disabled = {
+                "instance": "1.40.8",
+                "plugins": {},
+                "disabledPlugins": {
+                    "example": {
+                        "installedAt": "2026-06-14T17:18:40Z",
+                        "disabledAt": "2026-06-14T17:20:00Z",
+                        "files": [
+                            {
+                                "path": "Plugins/Example.dll",
+                                "sha256": sha256_file(asset),
+                                "size": asset.stat().st_size,
+                            }
+                        ],
+                    }
+                },
+            }
+            from plugin_helper.state import save_installed_state
+
+            save_installed_state(state, "1.40.8", disabled)
+
+            with patch("plugin_helper.cli.repo_root", return_value=work):
+                status = run(
+                    [
+                        "--instances-root",
+                        str(instance_root),
+                        "--state-dir",
+                        str(state),
+                        "enable",
+                        "--instance",
+                        "1.40.8",
+                        "example",
+                    ]
+                )
+
+            self.assertEqual(status, 0)
+            self.assertEqual((instance / "Plugins" / "Example.dll").read_bytes(), b"managed dll")
+            updated = load_installed_state(state, "1.40.8")
+            self.assertIn("example", updated["plugins"])
+            self.assertNotIn("example", updated["disabledPlugins"])
+
    def test_zip_to_pending_targets_ipa_pending(self) -> None:
        with tempfile.TemporaryDirectory() as tmp:
            work = Path(tmp)